Draft
Conversation
Every plugin is expected to expose a feature which means it works. This uses a shared example to test it in various places.
ekohl
commented
Dec 1, 2025
Member
Author
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Looks like the container gateway somehow doesn't start up and crashes, but we don't have the logs in acceptance tests.
Comment on lines
+19
to
+20
| cert_dir = '/etc/foreman-proxy' | ||
| describe curl_command("https://#{host_inventory['fqdn']}:8443/features", cacert: "#{cert_dir}/certificate.pem", cert: "#{cert_dir}/certificate.pem", key: "#{cert_dir}/key.pem") do |
Member
Author
There was a problem hiding this comment.
Actually, we don't need client auth so can be simplified to:
Suggested change
| cert_dir = '/etc/foreman-proxy' | |
| describe curl_command("https://#{host_inventory['fqdn']}:8443/features", cacert: "#{cert_dir}/certificate.pem", cert: "#{cert_dir}/certificate.pem", key: "#{cert_dir}/key.pem") do | |
| describe curl_command("https://#{host_inventory['fqdn']}:8443/features", cacert: '/etc/foreman-proxy/certificate.pem') do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every plugin is expected to expose a feature which means it works. This uses a shared example to test it in various places.